New engine options, "allow-direct-routing" and "trusted_host_interfaces" #22601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
area/engine
ArthurFlag
reviewed
May 30, 2025
robmry
force-pushed
the
moby_trusted_interfaces
branch
from
70f9fba to
824c257
Compare
ArthurFlag
previously approved these changes
May 30, 2025
3 tasks
thaJeztah
reviewed
May 30, 2025
Comment on lines
154
to
155
| Docker host. This can be achieved using static routes, Border Gateway Protocol | ||
| (BGP), or any other means appropriate for your network. For example, within |
Member
There was a problem hiding this comment.
- opened a quick PR to make vale happy on this acronym; vale: add "BGP" (Border Gateway Protocol) to acronyms #22731
thaJeztah
reviewed
May 30, 2025
Comment on lines
166
to
167
| Linux bridge network, use daemon option `--allow-direct-routing` or the | ||
| equivalent `"allow-direct-routing": true` in `/etc/docker/daemon.json`. |
Member
There was a problem hiding this comment.
Nit: not sure if we're consistent on this, but generally, I think we recommend users to use daemon.json for configs, so perhaps we should document that as the first option to set this (with the --allow-direct-routing command-line option as alternative)
thaJeztah
reviewed
May 30, 2025
| the host's loopback interface: | ||
|
|
||
| ```console | ||
| docker run -d --ip 192.0.2.100 -p 127.0.0.1:8080:80 nginx |
Member
There was a problem hiding this comment.
Can you add a prompt here?
Suggested change
| docker run -d --ip 192.0.2.100 -p 127.0.0.1:8080:80 nginx | |
| $ docker run -d --ip 192.0.2.100 -p 127.0.0.1:8080:80 nginx |
thaJeztah
previously approved these changes
May 30, 2025
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
left two comments / suggestions, but looks good after those are looked at, thanks!
Signed-off-by: Rob Murray <[email protected]>
robmry
force-pushed
the
moby_trusted_interfaces
branch
from
824c257 to
b11da57
Compare
Contributor
Author
|
I think this can be merged now, 28.2 shipped last week (https://github.com/moby/moby/releases/tag/v28.2.0). |
ArthurFlag
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update is for moby 28.2.0 - do not merge until it ships.- 28.2 has shipped now.Add description for daemon option
--allow-direct-routingand network optioncom.docker.network.bridge.trusted_host_interfaces.Related issues or tickets
moby/moby#49832
Reviews